[ 
https://issues.apache.org/jira/browse/BLUR-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527684#comment-13527684
 ] 

Aaron McCurry commented on BLUR-44:
-----------------------------------

I think what you have there is a good start.  In the convert method we need to 
handle if the cladd def is an IndexableFieldFactory class as well.  Also if 
it's neither then we should throw an exception so that invalid BlurAnalyzers 
cannot be created.  I think the store map should probably be moved to that 
managing object I talked about in #2.  Maybe we should call that class 
FieldManager?  It could handle creating the fields with the appropriate 
Store/No Store, Index/No Index, etc. and the BlurAnalyzer can just be a mapping 
of analyzers?  What do you think?  Thanks!


                
> Update BlurAnalyzer to use the Blur Thrift Analyzer object.
> -----------------------------------------------------------
>
>                 Key: BLUR-44
>                 URL: https://issues.apache.org/jira/browse/BLUR-44
>             Project: Apache Blur
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>         Environment: 0.2-dev-removing-old-thrift branch
>            Reporter: Aaron McCurry
>             Fix For: 0.2.0
>
>         Attachments: BlurAnalyzer.java
>
>
> The BlurAnalyzer constructor that takes a 
> org.apache.blur.thrift.generated.Analyzer currently does nothing.  Obviously 
> this needs to be implemented, I have added javadocs to the Blur thrift API 
> that describes the expected behavior.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to