On Fri, Jan 8, 2010 at 11:45 AM, Danny <[email protected]> wrote:
> 1. The replacement of '\r\n' and '\r' to '\n' should better be done
> after loading page, for convenience of modifying the source. For
> example, someone may find problematic when modifying data in a source
> and it wouldn't work since Windows consider linebreaks '\r\n' instead
> of '\n'.
It is done in BOLTloadpage already. But it seems it should also be
done when saving, or else the escape pattern doesn't match properly,
and the security fix doesn't work.
> Other fixes:
> The line in BOLTFoverwrite:
> if ($pages == '') return BOLTmsg('function_overwrite_nopages');
> should be:
> if ($pages == '') return BOLTmsg('func_overwrite_nopages');
Thanks, fixed.
> 2. I fixed several things in site.language, including duplicated,
> missed, and missorted items or so. The list is very long, so I
> uploaded the fixed file to this Google Group.
Don't see the file on Google Group. Did you upload them? You can also
email them offlist if you wish. I need a better sorting program. My
software just sorted the first word. I could do better myself with
BoltWire. Hey thats an idea!
But more seriously--we need a better solutions for the system
messages. I'm still thinking about your suggestions. Will explore some
possibilities in the near future.
> There are still problems for the translation. If the translated text
> in >> << contains some markups that goes before translation markup,
> their value would change first so the translation list won't recognise
> them. For example: /= =/, `, {vars}.
>
> The affected pages noted so far are listed below:
> site.config line 1 -- Fixed
> site.plugins line 1 -- Fixed
> site.script line 3 -- Fixed
> action.history lower -- Fixed
> action.upload lower -- ???
>
> And also some sentenses like:
> "Page renamed from {p} to {=page} by {=author} :: "
Ok, I've tried to fix most of these. Some by removing the translation
marks. Others by changing the content of the message to avoid trouble.
:) We could perhaps move the translation table up in the markup table
to the end of the "pre" order. That's perhaps a better solution. I'll
try that as well just to see if we don't have any problems with it.
> 3. It seems that there's a problem of [if] condition. Several pages
> are significantly affected:
> action.delete
> action.plugins
>
> I think it's due to the deletion of the 2nd line of the following:
> $condition = BOLTstripslashes($condition);
> $condition = str_replace('&&', '&&', $condition);
Yep. Probably so. I will fix that.
> 4. All "return BOLTmsg(~" is not correct since it adds a message box
> on the page. See action.plugins.
Ok. I'm thinking about that. Nice to have the messages, but there
ought to be a way to turn them off, also...
> 5. 'save' in the following 2 lines should be uppercase 'SAVE':
>
> BOLTreplace('~~~', "[[~.$BOLTid|$BOLTmember]], " . strftime('%x'),
> 'save');
> BOLTreplace('~~', "[[~.$BOLTid|$BOLTmember]]", 'save');
You are right! Great... Keen eye.
> 5. I'm confused what it means... you were going to change >|> to
> > were you?
>
> MarkUp('fmt', 'indent', '/\-(>|>)\n?/', '<blockquote>'); // -> <-
> indent (blockquote)
> MarkUp('fmt', 'indentend', '/\n?(<|<)\-/', '</blockquote>'); // ->
> <- indent (blockquote)
> //MarkUp('fmt', 'indent', '/\-\>\n?/', '<blockquote>'); // -> <-
> indent (blockquote)
> //MarkUp('fmt', 'indentend', '/\n?<\-/', '</blockquote>'); // -> <-
> indent (blockquote)
No, I prefer to keep the option in--in case something isn't encoded
somewhere properly it still matches the pattern.
> 6. A small thing for html markup. I think it would be better if we
> allow no space backward:
> old:
> MarkUp('style', 'html', '/<([\/]?)([a-z0-9]+)( \/)?>/ie',
> "BOLTMhtml('$1', '$2', '$3')"); // allowed html
> new:
> MarkUp('style', 'html', '/<([\/]?)([a-z0-9]+)( ?\/)?>/ie',
> "BOLTMhtml('$1', '$2', '$3')"); // allowed html
Actually, my pattern doesn't. But your pattern would allow <br/>. Do
we want that? Guess so...
> 7. If site language is not default, the page is saved instead of
> preview even when we click "PREVIEW". I'm not yet sure where the
> problem is. But if I write a config file which specifies a site
> language in v3.3.2 , I get the same problem.
I'm sure it is because the conditional running those buttons are not
translated. Please try changing a line like this
[session if "equal '{=boltsubmit}' 'PREVIEW' ? warn=Preview Mode."]
to
[session if "equal '{=boltsubmit}' '>>PREVIEW<<' ? warn=Preview Mode."]
and see if it doesn't fix things. If it does, I'll go through and make
the changes.
> 8. For picky optomizations:
>
> 1) The line in BOLTauth should be unneeded since we already do the
> replace several lines before:
> $f = str_replace('{id}', $BOLTid, $f);
Correct.
> 2) The comment of BOLTXrename should be rewritten:
> ## GIVES NEW NAMES TO EXISTING PAGES, RETAINING ALL CONTENT AND DATA,
> ETC. FORMAT OF $value LOOKS LIKE oldpage|newpage
You mean, change it to
GIVE NEW NAME TO EXISTING PAGE...
I've don't that but I'm not sure that's what you meant... I really
appreciate your suggestions!!!
Cheers,
Dan
--
You received this message because you are subscribed to the Google Groups
"BoltWire" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/boltwire?hl=en.
