[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187752#comment-13187752
 ] 

Ivan Kelly commented on BOOKKEEPER-153:
---------------------------------------

but the case of the topic being mapped to a ledger whose metadata is empty 
shouldn't exist anymore due to the fix in LedgerCreateOp. Of course, something 
else could break the metadata, but it won't be our code. 

My problem with the LedgerOpenOp changes are that they add a special case, and 
a fair bit of code, for a condition that should never happen. 
                
> Ledger can't be opened or closed due to zero-length metadata
> ------------------------------------------------------------
>
>                 Key: BOOKKEEPER-153
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-153
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-client
>    Affects Versions: 4.0.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.1.0
>
>         Attachments: BK-153.patch
>
>
> Currently creating ledger path and writing ledger metadata are not in a 
> transaction. so if the bookkeeper client (hub server uses bookkeeper client) 
> is crashed, we have a ledger existed in zookeeper with zero-length metadata. 
> we can't open/close it.
> we should create the ledger path with initial metadata to avoid such case. 
> besides that, we need to add code in openLedgerOp to handle zero-length 
> metadata for backward compatibility.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to