[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188138#comment-13188138
 ] 

Sijie Guo commented on BOOKKEEPER-153:
--------------------------------------

I don't like the changes in LedgerOpenOp either. 

The ledgers created using this patch would never encounter such problem. My 
concern is that the data/metadata generated by old code, do we need to handle 
them in new code? The zero-length-metadata ledgers did exist in the system 
using BOOKKEEPER-4.0.0. How we handle them when user upgrade it from 4.0.0 to 
4.1.0?
                
> Ledger can't be opened or closed due to zero-length metadata
> ------------------------------------------------------------
>
>                 Key: BOOKKEEPER-153
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-153
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-client
>    Affects Versions: 4.0.0
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.1.0
>
>         Attachments: BK-153.patch
>
>
> Currently creating ledger path and writing ledger metadata are not in a 
> transaction. so if the bookkeeper client (hub server uses bookkeeper client) 
> is crashed, we have a ledger existed in zookeeper with zero-length metadata. 
> we can't open/close it.
> we should create the ledger path with initial metadata to avoid such case. 
> besides that, we need to add code in openLedgerOp to handle zero-length 
> metadata for backward compatibility.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to