[
https://issues.apache.org/jira/browse/BOOKKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196021#comment-13196021
]
[email protected] commented on BOOKKEEPER-135:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3642/#review4685
-----------------------------------------------------------
I'm thinking I should add something more explicit to allow the client see that
the actual issue is the wrong password, maybe by throwing a different
exception, or logging a very explicit error message.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
<https://reviews.apache.org/r/3642/#comment10426>
This isn't were the error would come from in the case of wrong password for
fencing. Listener here is only for writing to the socket. Once you've written
to the socket the callback is invoked.
For wrong password errors, we have to wait for the response from the
bookie, which is handled in #messageReceived, and in this case by
#handleReadResponse, which will interpret the rc as a ReadException. When
LedgerRecoveryOp#readEntryComplete receives ReadException for all of the read
requests, it throws a LedgerRecoveryException to the client.
- Ivan
On 2012-01-26 19:26:03, Ivan Kelly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3642/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-26 19:26:03)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. When fencing, the ledger handle is not checked before the fencing is
applied. Currently the openLedger does fail, on because it will addEntry and
fail at that point, but by this stage, fencing has already been applied. The
check should be earlier.
bq.
bq.
bq. This addresses bug BOOKKEEPER-135.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-135
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
cb3bb26
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
4625bbb
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
29070eb
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
43e999d
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java
4466ce3
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java
bc1cfb0
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
beab5e8
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
2fa79bb
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java
8526db5
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java
015e4e4
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java
99d6ef0
bq.
bq. Diff: https://reviews.apache.org/r/3642/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ivan
bq.
bq.
> Fencing does not check the ledger masterPasswd
> ----------------------------------------------
>
> Key: BOOKKEEPER-135
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-135
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-135.diff
>
>
> When fencing, the ledger handle is not checked before the fencing is applied.
> Currently the openLedger does fail, on because it will addEntry and fail at
> that point, but by this stage, fencing has already been applied. The check
> should be earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
