[
https://issues.apache.org/jira/browse/BOOKKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205602#comment-13205602
]
[email protected] commented on BOOKKEEPER-135:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3642/
-----------------------------------------------------------
(Updated 2012-02-10 18:21:40.588207)
Review request for bookkeeper.
Summary
-------
When fencing, the ledger handle is not checked before the fencing is applied.
Currently the openLedger does fail, on because it will addEntry and fail at
that point, but by this stage, fencing has already been applied. The check
should be earlier.
This addresses bug BOOKKEEPER-135.
https://issues.apache.org/jira/browse/BOOKKEEPER-135
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
57a6c29
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java
3e96d46
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java
9da4aec
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java
911c660
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java
56186ab
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
4625bbb
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
7aad751
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
29070eb
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
43e999d
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java
8a32c64
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java
bc1cfb0
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
7217da6
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
a68fc8c
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java
cbd2277
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java
015e4e4
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java
99d6ef0
Diff: https://reviews.apache.org/r/3642/diff
Testing
-------
Thanks,
Ivan
> Fencing does not check the ledger masterPasswd
> ----------------------------------------------
>
> Key: BOOKKEEPER-135
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-135
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-135.diff, BOOKKEEPER-135.diff
>
>
> When fencing, the ledger handle is not checked before the fencing is applied.
> Currently the openLedger does fail, on because it will addEntry and fail at
> that point, but by this stage, fencing has already been applied. The check
> should be earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
