[
https://issues.apache.org/jira/browse/BOOKKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241253#comment-13241253
]
[email protected] commented on BOOKKEEPER-135:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3642/#review6519
-----------------------------------------------------------
the whole patch is very good. I just have some slight comments as below.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
<https://reviews.apache.org/r/3642/#comment14182>
just curious, do we need any cases to test different version compatibility?
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
<https://reviews.apache.org/r/3642/#comment14183>
it would better to define 20 as constant, since there is several places
referencing it.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
<https://reviews.apache.org/r/3642/#comment14181>
it would better to throw a BookieException, so it would be caught as EUA
error.
- Sijie
On 2012-03-20 18:13:56, Ivan Kelly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3642/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-20 18:13:56)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. When fencing, the ledger handle is not checked before the fencing is
applied. Currently the openLedger does fail, on because it will addEntry and
fail at that point, but by this stage, fencing has already been applied. The
check should be earlier.
bq.
bq.
bq. This addresses bug BOOKKEEPER-135.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-135
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
ad41ba5
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java
911c660
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java
56186ab
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
c67a79c
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
7aad751
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
539d6b2
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
7dd5363
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java
8a32c64
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java
8598c08
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
1a315e1
bq.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
75a8e8c
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java
b8923e8
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java
7de1c10
bq.
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java
99d6ef0
bq.
bq. Diff: https://reviews.apache.org/r/3642/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ivan
bq.
bq.
> Fencing does not check the ledger masterPasswd
> ----------------------------------------------
>
> Key: BOOKKEEPER-135
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-135
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-135.diff, BOOKKEEPER-135.diff,
> BOOKKEEPER-135.diff, BOOKKEEPER-135.diff
>
>
> When fencing, the ledger handle is not checked before the fencing is applied.
> Currently the openLedger does fail, on because it will addEntry and fail at
> that point, but by this stage, fencing has already been applied. The check
> should be earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
