[
https://issues.apache.org/jira/browse/BOOKKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242540#comment-13242540
]
[email protected] commented on BOOKKEEPER-135:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3642/
-----------------------------------------------------------
(Updated 2012-03-30 16:58:23.130753)
Review request for bookkeeper.
Changes
-------
Addressed Sijie's comments
Summary
-------
When fencing, the ledger handle is not checked before the fencing is applied.
Currently the openLedger does fail, on because it will addEntry and fail at
that point, but by this stage, fencing has already been applied. The check
should be earlier.
This addresses bug BOOKKEEPER-135.
https://issues.apache.org/jira/browse/BOOKKEEPER-135
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
ee38862
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java
911c660
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java
56186ab
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
c67a79c
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java
7aad751
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
539d6b2
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
7dd5363
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieClient.java
8a32c64
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java
8598c08
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
c5c1422
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
75a8e8c
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java
b8923e8
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java
7de1c10
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java
99d6ef0
Diff: https://reviews.apache.org/r/3642/diff
Testing
-------
Thanks,
Ivan
> Fencing does not check the ledger masterPasswd
> ----------------------------------------------
>
> Key: BOOKKEEPER-135
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-135
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-135.diff, BOOKKEEPER-135.diff,
> BOOKKEEPER-135.diff, BOOKKEEPER-135.diff, BOOKKEEPER-135.diff
>
>
> When fencing, the ledger handle is not checked before the fencing is applied.
> Currently the openLedger does fail, on because it will addEntry and fail at
> that point, but by this stage, fencing has already been applied. The check
> should be earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
