[
https://issues.apache.org/jira/browse/BOOKKEEPER-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295155#comment-13295155
]
Ivan Kelly commented on BOOKKEEPER-250:
---------------------------------------
Changes look very good. I have a few minor comments.
- ManagerLayout should use protobufs
- I think the "Persistence" methods on MetadataManager would be better as
"TopicPersistence" methods. i.e. writePersistenceInfo ->
writeTopicPersistenceInfo
- In writePersistenceInfo, i don't like how a special meaning is assigned to
operationFinished with null. It'd be better to call operationFailed, with a
custom error code for Conflicted version.
> Need a ledger manager like interface to manage metadata operations in Hedwig
> ----------------------------------------------------------------------------
>
> Key: BOOKKEEPER-250
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-250
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-250.diff, BOOKKEEPER-250.diff,
> BOOKKEEPER-250.diff_v2
>
>
> it would be better to a ledger-manager like interface to manage metadata
> operations in Hedwig, which might be easy for use to adapt to meta store api.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
