[
https://issues.apache.org/jira/browse/BOOKKEEPER-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411362#comment-13411362
]
Flavio Junqueira edited comment on BOOKKEEPER-250 at 7/11/12 10:04 AM:
-----------------------------------------------------------------------
I had a cursory at this patch, it is great work. I have only a couple of high
level comments that shouldn't hold this patch, but would be good to keep in
mind:
# It would be nice to have some documentation about it. I understand that this
is internal, but it would help anyone interested in having a different meta
store.
# Adding some more detail to javadocs would help to navigate through the code.
It is +1 for me.
was (Author: fpj):
I had a cursory at this patch, it is great work. I have only a couple of
high level comments that should hold this patch, but would be good to keep in
mind:
# It would be nice to have some documentation about it. I understand that this
is internal, but it would help anyone interested in having a different meta
store.
# Adding some more detail to javadocs would help to navigate through the code.
It is +1 for me.
> Need a ledger manager like interface to manage metadata operations in Hedwig
> ----------------------------------------------------------------------------
>
> Key: BOOKKEEPER-250
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-250
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-250.diff, BOOKKEEPER-250.diff,
> BOOKKEEPER-250.diff_v2, BOOKKEEPER-250.diff_v3, BOOKKEEPER-250.diff_v4,
> BOOKKEEPER-250.diff_v5, BOOKKEEPER-250.diff_v6
>
>
> it would be better to a ledger-manager like interface to manage metadata
> operations in Hedwig, which might be easy for use to adapt to meta store api.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
