[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401983#comment-13401983
 ] 

Sijie Guo commented on BOOKKEEPER-311:
--------------------------------------

as I comment in 
https://issues.apache.org/jira/browse/BOOKKEEPER-310?focusedCommentId=13401940&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13401940,
 it would be better to have a separated jira to support returning seq id for 
publish request, instead of putting them in different jiras.

Also, it would be better to make client related changes to both java and c++ 
client, to keep consistency between java & c++ clients. if they are too big to 
be in a single jira, it would be better to have a sub-task to handle c++ 
changes.

> ServerResponse

for responses, it would be PublishResponse not ServerResponse. I think you 
could leverage the method that I described in the comment of BOOKKEEPER-310.

> consume

changing consume behavior should be a separated jira to make things more 
clearly.




                
> Changes in hedwig client api to support JMS spec
> ------------------------------------------------
>
>                 Key: BOOKKEEPER-311
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-311
>             Project: Bookkeeper
>          Issue Type: Sub-task
>            Reporter: Mridul Muralidharan
>         Attachments: hedwig-client.patch
>
>
> Primary changes are :
> a) Add support for returning seq-id for a publish request. This is an api 
> change (backwardly compatible for users).
> b) Make consume a sync consume, with addition of an asyncConsume - this is to 
> ensure that invoking consume() ensure request makes to server before 
> returning (with what reasonable gaurantees that netty allows).
> c) Ensure that explicit close'ing of session will flush buffered consume 
> seq-id's when auto-ack is enabled (default in hedwig java client).
> In addition, there are also fixes for
> d) Fix NPE's observed as part of testing JMS provider.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to