[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407605#comment-13407605
]
Mridul Muralidharan commented on BOOKKEEPER-311:
------------------------------------------------
Splitting into
a) consume patch - which deals with changes to consume methods and changes to
ensure that consume() message buffering do not get lost on close().
The callback changes from (b) do overlap (partially) with this.
b) Changes to publish method(s) to return the PublishResponse to client. Also
includes changes to fix NPE's found while running the testcases.
hedwig-client.patch is no longer relevant.
Note that the protocol changes for (b) are NOT part of the patch since
generated code overlaps heavily with metadata changes.
The relevant difference to proto is a minor 5 line change :
{quote}
message RegionSpecificSeqId {
@@ -138,6 +166,18 @@ message PubSubResponse{
optional Message message = 5;
optional bytes topic = 6;
optional bytes subscriberId = 7;
+
+ // the following fields are sent by other requests
+ optional ResponseBody responseBody = 8;
+}
+
+message PublishResponse {
+ // If the request was a publish request, this was the message Id of the
published message.
+ required MessageSeqId publishedMsgId = 1;
+}
+
+message ResponseBody {
+ optional PublishResponse publishResponse = 1;
}
{quote}
> Changes in hedwig client api to support JMS spec
> ------------------------------------------------
>
> Key: BOOKKEEPER-311
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-311
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Mridul Muralidharan
> Attachments: hedwig-client.patch
>
>
> Primary changes are :
> a) Add support for returning seq-id for a publish request. This is an api
> change (backwardly compatible for users).
> b) Make consume a sync consume, with addition of an asyncConsume - this is to
> ensure that invoking consume() ensure request makes to server before
> returning (with what reasonable gaurantees that netty allows).
> c) Ensure that explicit close'ing of session will flush buffered consume
> seq-id's when auto-ack is enabled (default in hedwig java client).
> In addition, there are also fixes for
> d) Fix NPE's observed as part of testing JMS provider.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
