[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402937#comment-13402937
 ] 

Sijie Guo commented on BOOKKEEPER-309:
--------------------------------------

{quote}
I might be better off simply splitting the patches if reviewing them is causing 
problems 
{quote}

Splitting tasks by features is better to track dependencies and also good for 
reviewing.

{quote}
Is there a need for generic metadata in hedwig ? If yes, then we have to do it 
such that the metadata types supported in JMS are part of it.
{quote}

Having a generic header in Hedwig Message is necessary for both BOOKKEEPER-321 
and BOOKKEEPER-308. I found that there is a jira BOOKKEEPER-78. we could 
discuss on it to reach an agreement what kind of message header adding for 
hedwig message.

{quote}
What sort of interoperability is being considered between various producers and 
consumers - our assumption was there must be as much as possible (except for 
domain specific things like Serializable message type, etc).
{quote}

It is a good point. Allowing interoperability is quite complex for a system 
supporting different protocols (for this jira, we have native hedwig protocol 
and jms protocol). It is an application-dependent work to avoid and resolve. 
One possible work could be done in hedwig is adding message type in header of 
hedwig message to let different protocol provider know what type of message it 
received.
Let me summary my idea of Message Header on BOOKKEEPER-78. so we could have 
more discussion and try to reach agreement on it.
                
> Protocol changes in hedwig to support JMS spec
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-309
>             Project: Bookkeeper
>          Issue Type: Sub-task
>            Reporter: Mridul Muralidharan
>         Attachments: hedwig-protocol.patch
>
>
> JMS spec compliance requires three changes to the protocol.
> a) Support for message properties.
> b) Make body optional (message contains only properties).
> c) Return the published message's seq-id in the response.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to