[
https://issues.apache.org/jira/browse/BOOKKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407657#comment-13407657
]
Sijie Guo commented on BOOKKEEPER-309:
--------------------------------------
> Protocol changes for adding metadata.
How is the proposal to add MessageHeader I proposed in BOOKKEEPER-78?
> The diffs also overlap with client publish changes.
Since the protocol changes for client publish is introduced for BOOKKEEPER-310
and BOOKKEEPER-311, why not put them together? Because the publish you changed
could only work after BOOKKEEPER-309, BOOKKEEPER-310 and BOOKKEEPER-311 are in.
As my previous comment, I suggested you split you sub-tasks by features, each
feature is done as a jira. so if a jira is committed, the feature is available.
following this practice, BOOKKEEPER-308 could be separated by several features.
1) message header : include protobuf changes for message header.
2) publish changes : include protobuf changes for publish response, hedwig
client & server side changes to support returning message seq id for publish
request.
3) consume changes
4) jms provider.
so each feature could be a jira. since there is protobuf changes in both 1) and
2), you could generate the patch of 2) based on 1).
does it make sense for you?
> Protocol changes in hedwig to support JMS spec
> ----------------------------------------------
>
> Key: BOOKKEEPER-309
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-309
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Mridul Muralidharan
> Attachments: hedwig-protocol.patch, hedwig-protocol.patch.1
>
>
> JMS spec compliance requires three changes to the protocol.
> a) Support for message properties.
> b) Make body optional (message contains only properties).
> c) Return the published message's seq-id in the response.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
