[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409430#comment-13409430
 ] 

Sijie Guo commented on BOOKKEEPER-309:
--------------------------------------

{quote}
Or did I miss something ?
{quote}

that's why I suggested you to split BOOKKEEPER-308 by features. so we could 
focus discussion on specified feature at a single jira instead of spreading it 
over different jiras. 

{quote}
If I understand this correctly, it will mean that it will not be possible for 
publisher's using jms provider to interact with hedwig clients (and vice versa) 
right ?
As in, clients which depends only on body will now see body plus metadata 
encoded within ?
If that is the case, then I dont think we should pursue it ...
{quote}

as I described on BOOKKEEPER-78 ( 
https://issues.apache.org/jira/browse/BOOKKEEPER-78?focusedCommentId=13403094&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13403094
 ), different protocols could leverage a system property 'messageType' in 
MessageHeader to know how to encode/decode the data according to its protocol. 
I think it could resolve interoperability issue you care about.

{quote}
It does not allow for interoperability for and via message headers.
{quote}

I think what you need is tell the messages published from different kind of 
publishers. I think 'messageType' in MessageHeader as proposed in BOOKKEEPER-78 
could resolve your concern.

{quote}
When message headers stabilize further in hedwig, particularly for server side 
filtering, etc; we will need to reimplement this piece in provider.
{quote}

I don't think you need to do lots of work. From a generic view, a message 
filter would answer true or false when giving a Message. for you client-side 
filter now, you could get header from the message, do filtering logic, and 
return true or false. server-side fileter just enable you run it in server-side 
without doing nothing.

actually we just finished the message filter work and I would attach the 
patches these two days to let you see whether it makes sense for you or not.

                
> Protocol changes in hedwig to support JMS spec
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-309
>             Project: Bookkeeper
>          Issue Type: Sub-task
>            Reporter: Mridul Muralidharan
>         Attachments: hedwig-protocol.patch, hedwig-protocol.patch.1
>
>
> JMS spec compliance requires three changes to the protocol.
> a) Support for message properties.
> b) Make body optional (message contains only properties).
> c) Return the published message's seq-id in the response.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to