[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409345#comment-13409345
 ] 

Uma Maheswara Rao G commented on BOOKKEEPER-2:
----------------------------------------------


nit: BookKeeperAdmin: one unused import for DigestType.
as we are touching the file, I would suggest clean the imports as well.

One question: since this is a metadat change, do we need to up the 
MetaDataVersion number, and add the version checks on deserialing digestType 
and metadat for more safe?

@Sijie, It would be great if you take a look on it beased on your time?
                
> bookkeeper does not put enough meta-data in to do recovery properly
> -------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-2
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-2
>             Project: Bookkeeper
>          Issue Type: Sub-task
>            Reporter: Benjamin Reed
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-2.diff, BOOKKEEPER-2.diff
>
>
> somewhere, probably zookeeper, we need to keep track of the the information 
> about keys used for access and for mac validation as well as the digest type 
> for entries. we can't write a general recovery tool without it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to