[
https://issues.apache.org/jira/browse/BOOKKEEPER-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410071#comment-13410071
]
Sijie Guo commented on BOOKKEEPER-2:
------------------------------------
the patch is good, but I had several questions:
1) since we stored passwd and digest type on ledger metadata, if user provided
wrong digest type or wrong passwd to open the ledger, why we don't fail the
open request?
And also in test cases I found you used fixed digestType to open the ledger.
but the test cases would be ran with different digest types. The test case
would create a ledger using DigestType.CRC32 and open it using DigestType.MAC.
Do we allow doing this?
{code}
+ LedgerHandle lh = bkc.createLedger(3, 2, digestType, passwdA);
+ lh = bkc.openLedgerNoRecovery(ledgerId, BookKeeper.DigestType.MAC,
passwdA);
{code}
2) ensurePasswordUsedForOldLedgers is a kind of backward compatibility test.
why not move it to TestBackwardCompat? so we could know all incompatibles from
a central entry.
> bookkeeper does not put enough meta-data in to do recovery properly
> -------------------------------------------------------------------
>
> Key: BOOKKEEPER-2
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-2
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Benjamin Reed
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-2.diff, BOOKKEEPER-2.diff
>
>
> somewhere, probably zookeeper, we need to keep track of the the information
> about keys used for access and for mac validation as well as the digest type
> for entries. we can't write a general recovery tool without it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
