[
https://issues.apache.org/jira/browse/BOOKKEEPER-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411698#comment-13411698
]
Ivan Kelly commented on BOOKKEEPER-2:
-------------------------------------
New patch addresses comments and fixes some other minor issues.
{quote}
1) since we stored passwd and digest type on ledger metadata, if user provided
wrong digest type or wrong passwd to open the ledger, why we don't fail the
open request?
{quote}
If the user provides the wrong password and digest to openLedger, it now fails.
However, if the user configures a incorrect recovery password or digest, and
the ledger has the correct password in the metadata already, no failure occurs
during recovery, as all the necessary information is available.
{quote}
2) ensurePasswordUsedForOldLedgers is a kind of backward compatibility test.
why not move it to TestBackwardCompat? so we could know all incompatibles from
a central entry.
{quote}
It needs some things like #verifyFullyReplicated, which are only in
BookieRecoveryTest.
> bookkeeper does not put enough meta-data in to do recovery properly
> -------------------------------------------------------------------
>
> Key: BOOKKEEPER-2
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-2
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Benjamin Reed
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-2.diff, BOOKKEEPER-2.diff, BOOKKEEPER-2.diff
>
>
> somewhere, probably zookeeper, we need to keep track of the the information
> about keys used for access and for mac validation as well as the digest type
> for entries. we can't write a general recovery tool without it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
