[
https://issues.apache.org/jira/browse/BOOKKEEPER-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459054#comment-13459054
]
Uma Maheswara Rao G commented on BOOKKEEPER-315:
------------------------------------------------
Hi Ivan,
{quote}
+ long numberOfEntriesToReplicate = lastEntryId - firstEntryId;
should be (lastEntryId - firstEntryId) + 1
{quote}
You are right, both side entries has to be considered. Thank a lot for noticing
it.
{quote}
In general, I think this splitting should be in LedgerFragmentReplicator,
rather than BookKeeperAdmin. This way you could avoid the need to expose the
update of ledger metadata. It will make control flow a little more complex as
you'll have to initiate replication on the next subfragment from the callback
of the current, but i think it would encapsulate things a bit better.
{quote}
Yes, in general, all the split logic should be in LFR. I might pushed that code
to BKAdmin because, I don't want to disturb admin key flow much, which will go
through LFR.
Now anyway, I moved that logic, still not disturbing BKAdmin key flows in
anyway.
Attached a patch, which addresses the comments.
Also to give more confidence on split fragment scenarios, I have added multiple
boundary cases for FragmentSplit.
Thanks a lot, Ivan for your nice reviews!
> Ledger entries should be replicated sequentially instead of parallel.
> ---------------------------------------------------------------------
>
> Key: BOOKKEEPER-315
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-315
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery, bookkeeper-client
> Affects Versions: 4.2.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: BOOKKEEPER-315.patch, BOOKKEEPER-315.patch
>
>
> Currently BookKeeperAdmin will copy the entries parallel.
> This may create more load on the servers. To avoid that, we can refactor the
> BKAdmin code to copy the entries sequential.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
