[
https://issues.apache.org/jira/browse/BOOKKEEPER-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460583#comment-13460583
]
Ivan Kelly commented on BOOKKEEPER-315:
---------------------------------------
Hi Uma,
In ReplicationWorker, the setEntries.. is redundant, as it should have already
been copied in the constructor in the first line.
{code}
+ ClientConfiguration clientConf = new ClientConfiguration(conf);
+ clientConf.setEntriesPerSubFragmentInRereplication(this.conf
+ .getEntriesPerSubFragmentInRereplication());
{code}
{code}ENTRIES_PER_SUB_FRAGMENT_IN_REREPLICATION =
"entriesPerSubFragmentInRereplication";{code} is too long/wordy.
{code}REREPLICATION_ENTRY_BATCH_SIZE = "rereplicationEntryBatchSize"{code} is
clearer. Also, we don't want to expose the concept of fragments/subfragments to
the users. The less high level concepts we expose, the easier it is for them to
reason about what bookkeeper is doing.
Also, there's an inconsistency as to when splitting it occurring. Splitting
should happen for every fragment above the batch size. So the only entry point
to LedgerFragmentReplicator should be #replicate, and it should do the
splitting and replicating. You can pretty much do this by renaming
#splitAndReplicateFragment to #replicate, and #replicate to #replicateBatch,
but #replicate should be an async method still.
> Ledger entries should be replicated sequentially instead of parallel.
> ---------------------------------------------------------------------
>
> Key: BOOKKEEPER-315
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-315
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery, bookkeeper-client
> Affects Versions: 4.2.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: BOOKKEEPER-315.patch, BOOKKEEPER-315.patch
>
>
> Currently BookKeeperAdmin will copy the entries parallel.
> This may create more load on the servers. To avoid that, we can refactor the
> BKAdmin code to copy the entries sequential.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
