[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485887#comment-13485887
 ] 

Rakesh R commented on BOOKKEEPER-347:
-------------------------------------

@Vinay
I understood. I got confused after reading the comments in the patch.
{code}
+  // Just exclude the readonly bookies from available nodes
+  // list.
{code}

Instead could you please mention like:
"// Excluding 'readonly' znode from the available bookies list"
Also, we can directly remove the Bookie.READONLY as follows, in that case not 
required to have the checks inside loop:
{code}
children.remove(Bookie.READONLY);
{code}
                
>  Provide mechanism to detect r-o bookie by the bookie clients
> -------------------------------------------------------------
>
>                 Key: BOOKKEEPER-347
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-347
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-client
>    Affects Versions: 4.1.0
>            Reporter: Rakesh R
>            Assignee: Vinay
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-347.patch
>
>
> This jira to discuss, how the bookie client knows about the bookie running in 
> r-o. This would be required by the client to choose writable bookies during 
> add entries. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to