[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485907#comment-13485907
 ] 

Uma Maheswara Rao G commented on BOOKKEEPER-347:
------------------------------------------------

{code}
for (String bookieAddrString : children) {
+            if (Bookie.READONLY.equals(bookieAddrString)) {
+                // Just exclude the readonly bookies from available nodes
+                // list.
+                continue;
+            }
{code}

I think there is a potential issue here.
When you simply exclude the r-o bookie from newBookieAddrs set, we will simply 
consider the remaining bookies as dead Bookies and will close all the 
connections. Closing connections for writers may be ok, but this is not at all 
correct for readers as we will allow reading the r-o bookies.
                
>  Provide mechanism to detect r-o bookie by the bookie clients
> -------------------------------------------------------------
>
>                 Key: BOOKKEEPER-347
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-347
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-client
>    Affects Versions: 4.1.0
>            Reporter: Rakesh R
>            Assignee: Vinay
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-347.patch
>
>
> This jira to discuss, how the bookie client knows about the bookie running in 
> r-o. This would be required by the client to choose writable bookies during 
> add entries. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to