[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507468#comment-13507468
 ] 

Ivan Kelly edited comment on BOOKKEEPER-347 at 11/30/12 5:21 PM:
-----------------------------------------------------------------

New patch looks good, but tests are failing so you should look into that. Also, 
there's a findbugs and 1 line which is too long.

Also, could you rename BKInvalidWriteOnReadOnlyBookieException to 
BKWriteToReadOnlyBookieException (and the other objects in that file named the 
same also).

                
      was (Author: ikelly):
    New patch looks good, but patches are failing so you should look into that. 
Also, there's a findbugs and 1 line which is too long.

Also, could you rename BKInvalidWriteOnReadOnlyBookieException to 
BKWriteToReadOnlyBookieException (and the other objects in that file named the 
same also).

                  
>  Provide mechanism to detect r-o bookie by the bookie clients
> -------------------------------------------------------------
>
>                 Key: BOOKKEEPER-347
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-347
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-client
>    Affects Versions: 4.1.0
>            Reporter: Rakesh R
>            Assignee: Vinay
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-347.patch, BOOKKEEPER-347.patch, 
> BOOKKEEPER-347.patch
>
>
> This jira to discuss, how the bookie client knows about the bookie running in 
> r-o. This would be required by the client to choose writable bookies during 
> add entries. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to