----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8038/#review13965 -----------------------------------------------------------
hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java <https://reviews.apache.org/r/8038/#comment29876> rename to metastore_impl_class hedwig-server/src/main/java/org/apache/hedwig/server/meta/MsMetadataManagerFactory.java <https://reviews.apache.org/r/8038/#comment29877> Where do these constants come from? hedwig-server/src/main/java/org/apache/hedwig/server/meta/MsMetadataManagerFactory.java <https://reviews.apache.org/r/8038/#comment29879> Again, shouldn't this be versioned? hedwig-server/src/main/java/org/apache/hedwig/server/meta/MsMetadataManagerFactory.java <https://reviews.apache.org/r/8038/#comment29878> Version.ANY? Shouldn't this be a versioned operation? - Ivan Kelly On Nov. 13, 2012, 1:51 p.m., Jiannan Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8038/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2012, 1:51 p.m.) > > > Review request for bookkeeper. > > > Description > ------- > > Implement a meta store based hedwig metadata manager. > > > This addresses bug BOOKKEEPER-262. > https://issues.apache.org/jira/browse/BOOKKEEPER-262 > > > Diffs > ----- > > > hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java > 520744a > > hedwig-server/src/main/java/org/apache/hedwig/server/meta/MsMetadataManagerFactory.java > PRE-CREATION > > hedwig-server/src/test/java/org/apache/hedwig/server/meta/MetadataManagerFactoryTestCase.java > e33b315 > > Diff: https://reviews.apache.org/r/8038/diff/ > > > Testing > ------- > > > Thanks, > > Jiannan Wang > >
