> On Dec. 3, 2012, 11:43 a.m., Ivan Kelly wrote: > > hedwig-server/src/test/java/org/apache/hedwig/server/meta/MetadataManagerFactoryTestCase.java, > > line 61 > > <https://reviews.apache.org/r/8038/diff/2/?file=189060#file189060line61> > > > > I'd like to see how long this adds to test times before committing. > > Jiannan Wang wrote: > So measure it by pre-commit after I update the patch? > > Ivan Kelly wrote: > I think it'd be better to just run on your dev machine without the patch, > and run again with the patch. and post the difference to the JIRA.
Okay - Jiannan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8038/#review13966 ----------------------------------------------------------- On Nov. 13, 2012, 1:51 p.m., Jiannan Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8038/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2012, 1:51 p.m.) > > > Review request for bookkeeper. > > > Description > ------- > > Implement a meta store based hedwig metadata manager. > > > This addresses bug BOOKKEEPER-262. > https://issues.apache.org/jira/browse/BOOKKEEPER-262 > > > Diffs > ----- > > > hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java > 520744a > > hedwig-server/src/main/java/org/apache/hedwig/server/meta/MsMetadataManagerFactory.java > PRE-CREATION > > hedwig-server/src/test/java/org/apache/hedwig/server/meta/MetadataManagerFactoryTestCase.java > e33b315 > > Diff: https://reviews.apache.org/r/8038/diff/ > > > Testing > ------- > > > Thanks, > > Jiannan Wang > >
