> On Dec. 3, 2012, 11:42 a.m., Ivan Kelly wrote: > > hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java, > > line 74 > > <https://reviews.apache.org/r/8038/diff/2/?file=189058#file189058line74> > > > > rename to metastore_impl_class
Will change > On Dec. 3, 2012, 11:42 a.m., Ivan Kelly wrote: > > hedwig-server/src/main/java/org/apache/hedwig/server/meta/MsMetadataManagerFactory.java, > > line 585 > > <https://reviews.apache.org/r/8038/diff/2/?file=189059#file189059line585> > > > > Again, shouldn't this be versioned? This patch is generated before BOOKKEEPER-440, will rebase the code. > On Dec. 3, 2012, 11:42 a.m., Ivan Kelly wrote: > > hedwig-server/src/main/java/org/apache/hedwig/server/meta/MsMetadataManagerFactory.java, > > line 632 > > <https://reviews.apache.org/r/8038/diff/2/?file=189059#file189059line632> > > > > Version.ANY? Shouldn't this be a versioned operation? Same as above. > On Dec. 3, 2012, 11:42 a.m., Ivan Kelly wrote: > > hedwig-server/src/main/java/org/apache/hedwig/server/meta/MsMetadataManagerFactory.java, > > line 511 > > <https://reviews.apache.org/r/8038/diff/2/?file=189059#file189059line511> > > > > Where do these constants come from? For subscription data, concat "topic" and "subId" as a key in MetaStore, and the we can scan the topic to get the subscriber list. These constants are used as separator for "topic" and "subId". - Jiannan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8038/#review13965 ----------------------------------------------------------- On Nov. 13, 2012, 1:51 p.m., Jiannan Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8038/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2012, 1:51 p.m.) > > > Review request for bookkeeper. > > > Description > ------- > > Implement a meta store based hedwig metadata manager. > > > This addresses bug BOOKKEEPER-262. > https://issues.apache.org/jira/browse/BOOKKEEPER-262 > > > Diffs > ----- > > > hedwig-server/src/main/java/org/apache/hedwig/server/common/ServerConfiguration.java > 520744a > > hedwig-server/src/main/java/org/apache/hedwig/server/meta/MsMetadataManagerFactory.java > PRE-CREATION > > hedwig-server/src/test/java/org/apache/hedwig/server/meta/MetadataManagerFactoryTestCase.java > e33b315 > > Diff: https://reviews.apache.org/r/8038/diff/ > > > Testing > ------- > > > Thanks, > > Jiannan Wang > >
