[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576362#comment-13576362
 ] 

Rakesh R commented on BOOKKEEPER-555:
-------------------------------------

Thanks [~ikelly], latest patch looks nice. Apart from the following point, the 
patch is ready to go in +1.

Just one clarification, latest patch BookieRequestHandler is not having 
@Sharable annotation. In my previous comment I mentioned to replace the 
@ChannelPipelineCoverage(which is deprecated) with @Sharable. Am I missing 
anything?
                
> Make BookieServer use Netty rather than a custom IO server
> ----------------------------------------------------------
>
>                 Key: BOOKKEEPER-555
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, 
> 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, 
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, 
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, 
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, BOOKKEEPER-555.patch
>
>
> Move from the custom NIO server to netty. This will make it easier to do 
> things like add more server side threads and support SSL.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to