[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576494#comment-13576494
 ] 

Ivan Kelly commented on BOOKKEEPER-555:
---------------------------------------

[~rakeshreddy] Re: @Sharable, you should put @Sharable on a ChannelHandler if 
more than one pipeline is going to use that ChannelHandler. Current we create a 
new handler per pipeline, and this doesn't seem to cause any performance 
issues. We could however share the ChannelHandler (and the decoder/encoder) as 
none of these actually old any state. However, I'd like to do that in a future 
JIRA and push this one in now, as there are a couple of things waiting on this.

Therefore, since I have a +1, I'm going to push in.
                
> Make BookieServer use Netty rather than a custom IO server
> ----------------------------------------------------------
>
>                 Key: BOOKKEEPER-555
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-555
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, 
> 0001-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, 
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, 
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, 
> 0002-BOOKKEEPER-555-Netty-Server-for-Bookie.patch, BOOKKEEPER-555.patch
>
>
> Move from the custom NIO server to netty. This will make it easier to do 
> things like add more server side threads and support SSL.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to