[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624238#comment-13624238
 ] 

Sijie Guo commented on BOOKKEEPER-564:
--------------------------------------

the patch here already covered the most part you made the change in 
BOOKKEEPER-572. the only thing is that we need a place to tracking checkpoints 
to ensure data in ledger storage are synced to disk before that checkpoint. (in 
bookkeeper-572, you tracks the checkpoints in SyncThread). but since 
checkpointing is a behavior of ledger storage, it would be better to keep 
checkpoint in ledger storage rather than in SyncThread, so it could control how 
to checkpoint. so either interleaved ledger storage or skiplist based on ledger 
storage could control when to do checkpointing based on its storage 
characteristics, rather than flushing everything in ledger storage in 
SyncThread. 
                
> Better checkpoint mechanism
> ---------------------------
>
>                 Key: BOOKKEEPER-564
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-564
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.3.0
>
>         Attachments: 0002-BOOKKEEPER-564-Better-checkpoint-mechanism.patch, 
> BOOKKEEPER-564.patch
>
>
> Currently, SyncThread made a checkpoint too frequently, which affects 
> performance. data is writing to entry logger file might be blocked by syncing 
> same entry logger file, which affect bookie to achieve higher throughput. We 
> could schedule checkpoint only when rotating an entry log file. so new 
> incoming entries would be written to newer entry log file and old entry log 
> file could be synced.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to