[
https://issues.apache.org/jira/browse/BOOKKEEPER-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626287#comment-13626287
]
Sijie Guo commented on BOOKKEEPER-564:
--------------------------------------
{quote}
In fact, I think you should get rid of separate #flush() and #checkpoint()
completely, as #flush only seems to be used when shutting down. So you can do
whatever flush is doing in the #shutdown() method.
{quote}
separate #flush and #checkpoint would make interface clearly rather than mixing
things in #shutdown method.
{quote}
Why make entrylogger preallocation optional?
{quote}
for testing stuffs.
{quote}
#checkpoint.checkpointComplete(running); so we only cleanup old journals on
shutdown?
{quote}
we expose as a compact flag, indicated whether we need to compact journals
after checkpoint. running means if sync thread is running, we compact each time
checkpoint. if running is false, it means shutting down. we don't compact
journal, which speed up shutting down process.
> Better checkpoint mechanism
> ---------------------------
>
> Key: BOOKKEEPER-564
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-564
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: 0002-BOOKKEEPER-564-Better-checkpoint-mechanism.patch,
> BOOKKEEPER-564.patch
>
>
> Currently, SyncThread made a checkpoint too frequently, which affects
> performance. data is writing to entry logger file might be blocked by syncing
> same entry logger file, which affect bookie to achieve higher throughput. We
> could schedule checkpoint only when rotating an entry log file. so new
> incoming entries would be written to newer entry log file and old entry log
> file could be synced.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
