[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626146#comment-13626146
 ] 

Jiannan Wang commented on BOOKKEEPER-552:
-----------------------------------------

{quote}
"competition" in the preamble of ZkBatchLedgerIdGenerator should be 
"contention" instead.
{quote}
Thanks for correcting, I'll update it with completed word "resource contention".

{quote}
in fetchLedgerIdBatch, you probably want to resubmit the getData operation in 
the case of a connection loss event.
{quote}
As [~hustlmsp]'s comment, the issue will be handled at that JIRA, so we don't 
need to treat it as a dependency, BOOKKEEPER-537 will fix this patch instead.

{quote}
Doesn't the metadata command wipe out any old data? Do we provide a way to 
migrate data or changing the number of slots is fixed and can't change once we 
start an instance, unless once is willing to wipe out its data? It is possibly 
not a big deal.
{quote}
The format command will also wipe out this number.

As above discussion, I'll store the number of slots in zookeeper. But I prefer 
adding TODO for it and handle it in new JIRA: there are some other information 
that requires consistent guarantee in zk (such as metastore class), which can 
be handled in a common style.
                
> 64 Bits Ledger ID Generation
> ----------------------------
>
>                 Key: BOOKKEEPER-552
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-552
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-client, bookkeeper-server, hedwig-server
>            Reporter: Jiannan Wang
>            Assignee: Jiannan Wang
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-552.patch, BOOKKEEPER-552.patch, 
> BOOKKEEPER-552.patch
>
>
> This task aims to find and implement 64 bits global unique ledger id 
> generation mechanisms.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to