[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626611#comment-13626611
 ] 

Flavio Junqueira commented on BOOKKEEPER-552:
---------------------------------------------

bq. actually, migration is complicated thing as we discussed last year. but as 
my understanding, if we want to proceed migration, at least we need to 
guarantee the target ledger metadata would generate ledger ids with source 
ledger manager in same ledger id space. so actually ledger id is an independent 
and critical metadata rather ledger metadata itself. so I would suggest the 
ledger format should be fixed during the life cycle of an instance.

Let me step back and say that my concern is that a user comes, sets the number 
of slots (NUM_SLOTS), starts running, and later on decides that it is possibly 
better to increase the number of slots. In my understanding, as is, the user 
wouldn't be able to do it. I find it a little harsh to force a user to make the 
right choice from the beginning. If we can solve this issue by making a 
guarantee about the namespace as you suggest, then I think it is fine.

bq. As Sijie Guo's comment, the issue will be handled at that JIRA, so we don't 
need to treat it as a dependency, BOOKKEEPER-537 will fix this patch instead.

We need to link the two jiras then.

bq. More specifically, on the ledger id generation, the critical thing is to 
make sure ledger id is generated in incremental way, or it might cause issue: 
ledger id that deleted before is possible to be reused again and if the 
ledger's metadata is removed in metadata storage while ledger data not been 
cleaned in bookie server then some of current logic is broken.

We have had this discussion before, but in a different context, when talking 
about ledger garbage collection. I don't understand how it fits into this 
discussion about id generation. Could you clarify, please?


                
> 64 Bits Ledger ID Generation
> ----------------------------
>
>                 Key: BOOKKEEPER-552
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-552
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-client, bookkeeper-server, hedwig-server
>            Reporter: Jiannan Wang
>            Assignee: Jiannan Wang
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-552.patch, BOOKKEEPER-552.patch, 
> BOOKKEEPER-552.patch
>
>
> This task aims to find and implement 64 bits global unique ledger id 
> generation mechanisms.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to