[
https://issues.apache.org/jira/browse/BOOKKEEPER-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627483#comment-13627483
]
Jiannan Wang commented on BOOKKEEPER-552:
-----------------------------------------
Actually my original consideration to split ledger id into different slots is
to reduce contention when acquire id range by zookeeper, NOT for ledger id
namespace partition. So (1<<13) slots are quite enough only for this purpose
(reduce contention), and user needn't to change it. (And why 1<<13? I'm just
choose this number for the convient of BOOKKEEPER-553)
While ledger id namespace partition is another topic. In my view, to achieve
ledger id namespace partition, we can build a namespace-partition
LedgerIdGenerator on top of existing ledger id generation class by reserving
some bits from the ledger id space.
{quote}
Let me step back and say that my concern is that a user comes, sets the number
of slots (NUM_SLOTS), starts running, and later on decides that it is possibly
better to increase the number of slots. In my understanding, as is, the user
wouldn't be able to do it. I find it a little harsh to force a user to make the
right choice from the beginning. If we can solve this issue by making a
guarantee about the namespace as you suggest, then I think it is fine.
{quote}
As my above comment, change slots number is not so meaningful for user.
{quote}
We need to link the two jiras then.
{quote}
It's fine to do it, but then any new patch (in other JIRA) that involves zk
operations also needs to link to BOOKKEEPER-537 from now on, which is quite
heavy. So instead of linking JIRA, I prefer a comment in BOOKKEEPER-537 to
remind the assignee take care of the new change. What's do you think?
{quote}
We have had this discussion before, but in a different context, when talking
about ledger garbage collection. I don't understand how it fits into this
discussion about id generation. Could you clarify, please?
{quote}
Our previous discussion is right in the first comment of this JIRA, and it's
the (3) case you mention before. I mention it again here is because we were
talking about changing NUM_SLOTS setting, and I want to remind that changing
the NUM_SLOTS should take care of this issue :)
> 64 Bits Ledger ID Generation
> ----------------------------
>
> Key: BOOKKEEPER-552
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-552
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server, hedwig-server
> Reporter: Jiannan Wang
> Assignee: Jiannan Wang
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-552.patch, BOOKKEEPER-552.patch,
> BOOKKEEPER-552.patch
>
>
> This task aims to find and implement 64 bits global unique ledger id
> generation mechanisms.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
