[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155166#comment-14155166
]
Sijie Guo commented on BOOKKEEPER-634:
--------------------------------------
- [~ikelly] limit sometime is useful for testing the tool. [~rakeshr] you just
ignored my comment again, as I said that if user doesn't provide [-limit], you
should iterate over all the ledgers, not just set a value like
Integer.MAX_VALUE.
- printing messages:
* It is not good idea to have printing operation in BookKeeperAdmin. It should
only be in BookieShell. BookKeeperAdmin is an admin client not a tool.
* please add an option [-verbose] for printing this messages.
* I'd rather prefer printing progress message every {N} ledgers, rather than
every {X} seconds. it is too noisy.
- -1 on Future.
* it is mixing callback with Future, which brings in too much inconsistent
styles in BookKeeperAdmin. I think we already have quite good pattern on
replication code about multiple callbacks. if we are sticking on the callback
styles, you don't even need to have a different set of status code. we should
only use a single set of status code, rather than introducing something
different, which make code maintenance complicated.
> Provide admin tool to rename bookie identifier in ledger metadata
> -----------------------------------------------------------------
>
> Key: BOOKKEEPER-634
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.2.1
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch,
> 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch,
> 002-BOOKKEEPER-634-rename-bookieid-in-ledger.patch,
> BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch,
> BOOKKEEPER-634.patch
>
>
> This JIRA to discuss about admin tool for changing the bookie's IP to
> hostname.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
