[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155175#comment-14155175
 ] 

Sijie Guo commented on BOOKKEEPER-634:
--------------------------------------

{quote}
One thing that's a little weird about the tool is that it only updates the 
ledgers for a single bookie. So for each bookie changed, you'll have to iterate 
over all ledgers. Not sure how to fix this cleanly though.
{quote}

This behavior also exists on replication tool. I have a fix to support multiple 
bookies. I think for now, let's starting with renaming a bookie first, we could 
iterate the change later to support renaming multiple bookies, with the change 
to support replicating multiple bookies.

{quote}
For this reason I think we need to be clearer on the scenarios in which a admin 
would use this tool, and also we need to be able to audit the ledgers to ensure 
that if we update a bookie id, it doesn't exist in the system and can't remerge 
in the system.
{quote}

the clear sequence for the admin tool:

1) cookie will be updated first, which hence bookie will be restarted and 
registered bookie id as different id.
2) every client will be aware of the book id change, since the 
available_bookies zookeeper path will be updated.
3) after this point, running updating ledger metadata will change the metadata 
version, hence the writers will have to re-read metadata in case of ensemble 
changing. so new ledger or new ensemble will use the new bookie id, while the 
old ledger metadata will be updated when re-reading on bad version.

 I think it is good so far. but we need to document this sequence anyway.

> Provide admin tool to rename bookie identifier in ledger metadata
> -----------------------------------------------------------------
>
>                 Key: BOOKKEEPER-634
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-client, bookkeeper-server
>    Affects Versions: 4.2.1
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch, 
> 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, 
> 002-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, 
> BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch, 
> BOOKKEEPER-634.patch
>
>
> This JIRA to discuss about admin tool for changing the bookie's IP to 
> hostname.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to