[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156087#comment-14156087
]
Rakesh R commented on BOOKKEEPER-634:
-------------------------------------
[~hustlmsp], [[email protected]] thanks both of you, many points has comeup
in recent discussions. Now its my turn to prepare a design doc capturing all
these points.
bq.you just ignored my comment again, as I said that if user doesn't provide
[-limit], you should iterate over all the ledgers, not just set a value like
Integer.MAX_VALUE.
once again thank you Sijie for the comments. It was a good point and I had
accepted it, also included in my yesterday's patch
{{002-BOOKKEEPER-634-rename-bookieid-in-ledger.patch}}. But I think I need to
improve and make it more clear rather than trying to reuse the
#getOptionIntValue method by using constant Integer.MIN_VALUE represents this
condition. Also, now I could see there is a bug in the condition, anyway I'll
correct it in my next patch.
{code}
+ final int limit = getOptionIntValue(cmdLine, "limit",
Integer.MIN_VALUE);
+ if (limit <= 0 && limit != Integer.MIN_VALUE) {
+ return -1;
+ }
{code}
{code}
+ if (limit != Integer.MIN_VALUE && updatedLedgerCount >= limit) {
+ break;
+ }
{code}
Regards,
Rakesh
> Provide admin tool to rename bookie identifier in ledger metadata
> -----------------------------------------------------------------
>
> Key: BOOKKEEPER-634
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.2.1
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.1
>
> Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch,
> 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch,
> 002-BOOKKEEPER-634-rename-bookieid-in-ledger.patch,
> BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch,
> BOOKKEEPER-634.patch
>
>
> This JIRA to discuss about admin tool for changing the bookie's IP to
> hostname.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
