Hi,

Sean has left the following comment at Integrate new thread affinity interface into LIBBU and LIBRT http://www.google-melange.com/gci/task/view/google/gci2012/8070202:


don't see the point


I don't see the point of fromParallelInt. Why can't cpu_id just get set within bu_parallel()? Avoiding those semaphore locks in parallel_interface_arg() was an intentional goal.

If it's a platform that uses parallel_interface(), the static globals still get used and the counter incremented as before. If it's a new platform using parallel_interface(), no static variable needs to be touched and it doesn't matter if they go unused.

Since the SGI case is one of the parallel_interface() args, that logic shouldn't also be in _arg().

Basically, everywhere you've replicated a section of code, it's not right. :)


Greetings,
The Google Open Source Programs Team


---
You are receiving this message because you are subscribed to Integrate new thread affinity interface into LIBBU and LIBRT. To stop receiving these messages, go to: http://www.google-melange.com/gci/task/view/google/gci2012/8070202.

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
BRL-CAD Tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker

Reply via email to