Hi,

Sean has left the following comment at Integrate new thread affinity interface into LIBBU and LIBRT http://www.google-melange.com/gci/task/view/google/gci2012/8070202:


nicely done


That's really looking great Akshay! Looks like this is wrapping up nicely. I only have one remainging question for you that I don't know the answer to myself.

So bu_parallel() has a user_thread_data_bu struct that is getting passed to thr_create(), pthread_create(), and CreateThread(). You reuse that struct for every thread, but does each thread retain its own copy?

Since it's the same struct that we're passing a pointer for and later incrementing that same cpu_id in the thread creation loops, is the cpu_id being incremented for all threads or is copied. A quick review of the docs for each of those three functions should confirm how that is handled. You may need to create N structs so each one is independent.

Note that you have a typo on two of the user_thread_data.cpu_id++'s where it's missing the _bu.


Greetings,
The Google Open Source Programs Team


---
You are receiving this message because you are subscribed to Integrate new thread affinity interface into LIBBU and LIBRT. To stop receiving these messages, go to: http://www.google-melange.com/gci/task/view/google/gci2012/8070202.

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
BRL-CAD Tracker mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-tracker

Reply via email to