> > This has nothing specifically to do with the proposed en-mii option, but > > is rather a general issue with link properties that can have a lot of > > values (such as cpus, WiFi speed, and undoubtedly others to come). We've > > discussed this before in a different context (dlstat) where there was a > > proposal to use the prefix "+" to add an item and "-" to remove an item. > > I think a similar approach could be used with link properties -- e.g.: > > > > * Assign en-mii to 100M-fh,10M: > > > > # dladm set-linkprop -p en-mii=100M-fh,10M-h link1 > > ^ > would you expect "show-linkprop" to display "en-mii"? That would > not be useful in this case because the enabled speed-duplex values is > typically a larger set than those that were administratively enabled.
Sorry, which field are you talking about displaying? > But there is another subtle problem to this proposal, which goes > back to the earlier discussion of setting multiple props in one line. > What if the set-linkprop of the items in the set fails? That's presuming an implementation where values have to be set individually, which is not required by the proposal. > Do we want the others to succeed? (my take on this, if we are actually > going to go forward with it at the end of the debate) is that one bad > value in this "en-mii" group should cause the whole thing to fail >From an end-user perspective that's the semantic you want, but I doubt there's a safe way to implement it since you can't necessarily put things back to the way they were initially. But again, this issue only arises if you presume a certain implementation. -- meem
