> > > and in the +=, -= world, how does one do "enable 100-h and disable > > 10-fh" > > > without using 2 commands > > > > With my proposal that would still have to be done with a set (=) > > operation. > > Today with the en_* and adv_* properties you can set a value (e.g., > en_10fdx_cap) to 0 or 1 - 0 means disable, 1 means enable. could you > give an example of how you would do this with the en-mii proposal (and > without the += or -=, and without listing the full set of speed/duplex > pairs in the command line)?
As per my earlier email, the proposal is not trying to support arbitrary transforms. If the admin has e.g. a SPEED-DUPLEX value of 100g-f,10m-h and they want to change the 10m-h value to 10m-f then they would need to enter 100g-f,10m-f, or first do -=10m-h followed by += of 10m-f. If they just want to add or remove a specific value then they can use += or -=. For instance, if they wanted to add CPU 12 to the list of cpus, they'd do set-linkprop -p cpus+=12. Is there a specific concern with such a model? > Also in today's model, only the modified setting (en_10fdx_cap = 0, > in my example) is saved in datalink.conf. As I understand, in your > proposal, the whole set of enabled props would have to get stored in > datalink.conf (and then, if the NIC is DR'ed or otherwise changes its > defaults, the stored set in datalink.conf may be out of sync). There are pros and cons with both approaches in the case of DR'd hardware. Are they overriding the setting because of a switch problem? A card problem? Just general confusion? Unclear, so it's hard to say what ideal behavior would be. -- meem
