On (06/17/09 04:34), Peter Memishian wrote: > > > As I understand it, the datalink.conf would have some line like > > en_mii=10g-f,1000M-fh,100M-.., 10M-.. > > (even if only one of these were modified from the default). > > I'm still confused; why wouldn't it just record just the delta they've > requested with += or -=?
I thought you were saying: > If the admin has e.g. a SPEED-DUPLEX value of 100g-f,10m-h > and they want to change the 10m-h value to 10m-f then they would need to > enter 100g-f,10m-f, or first do -=10m-h followed by += of 10m-f. and I was addressing the first part of that sentence. So it would not be possible to modify the existing set without a series of -= and += commands, and then "show-linkprop -p en-mii" would have to compute the union of all such commands so far to figure out what to print. My suggestion, otoh, would involve just one command that, to me, is more intuitive, and doesn't involve keeping track of all the +/- operations so far: dladm set-linkprop -p en-mii=no-10m-h,10m-f ... I'm not too crazy about the -= and += syntax. So far we have had a simple -p <name>=<value> interface, and now we are proposing that a subset of commands that may take the -/+ adjustment as a sort of "modify-linkprop". It adds a complexity, that as Garrett points out, seems like overkill for this case. But I still have to read Garrettt's proposal carefully.. --Sowmini
