On (04/01/08 14:04), Sebastien Roy wrote:
>
> usr/src/cmd/cmd-inet/usr.sbin/ndd.c
>
> * 74: You don't need "cp"; you can pass buf as an argument to
> dladm_get_linkprop, can you not?
buf is a pointer to char, dladm_get_linkprop needs a char *. It seems
more readable to just use cp
> * 75: Just verifying: Is it a fact that all links that support
> NDD-compatibility properties support the "flowctrl" property?
yes- the ndd compat is only applicable to ethernet
drivers that exploit ndd for driver conf (other drivers are
expected to use dladm directly), and these drivers will all support
the flowctrl property.
> * 109,304: This warning seems a bit too generic sounding. Not all ndd
> commands are obsolete.
>
> * 109,304: Not lint clean (need (void) cast for the fprintf() call).
>
> * 303,108: These are duplicate blocks of code. I'd rename isgldv3() to
> print_gldv3_warning() or some such thing and plop the fprintf() in there.
Ok, changed to
(void) fprintf(stderr,
"WARNING: The ndd commands for datalink administration "
"are obsolete and may be removed in a future release of "
"Solaris. Use dladm(1M) to manage datalink tunables\n");
printed from gldv3_warning (the renamed isgld3()).
See file:/net/zhadum.east/export/ws/sowmini/brussels/nddcompat_reg/webrev
--Sowmini
