Sowmini.Varadhan at Sun.COM wrote: > On (03/27/08 19:00), Peter Memishian wrote: >> Leaving aside SunVTS: couldn't ndd issue an ioctl to determine whether the >> driver has been converted and then issue the warning as appropriate? > > You can, but what ioctl should it issue? Do we invent a new ioctl or property > just to probe if the device has MC_SETPROP/MC_GETPROP? > One possibility is to just link libdladm into ndd and do a get_linkprop > e.g., see > http://zhadum.east/export/ws/sowmini/brussels/nddcompatchild/webrev > where I tried playing with this. But this is going to break any script > that parses the output of ndd (I've fprintf'ed to stderr, but I'm not > sure that covers every case).
I like the approach, and FWIW, I don't really care either way about the isatty() thing. Are you going to incorporate this into your main webrev, or would you like a review of this webrev? For example, I see that there's still a printf() debug statement in there, so I'm not sure if you're ready for it to be reviewed. -Seb
