On (03/29/08 08:23), Sebastien Roy wrote: > I like the approach, and FWIW, I don't really care either way about the > isatty() thing. Are you going to incorporate this into your main > webrev, or would you like a review of this webrev? For example, I see > that there's still a printf() debug statement in there, so I'm not sure > if you're ready for it to be reviewed.
Webrev has been updated to fix the printf. I think the isatty() check is probably safer to have, just as a sanity check. Could you review, please? I'll incorporate this into the main gate later this week, after I also fix the MAC_PERM -> MAC_PROP_PERM change from the code review comments. --Sowmini
