sowmini.varadhan at sun.com wrote:
> On (11/08/07 13:27), Garrett D'Amore wrote:
>
>> This is weird.
>>
>> Out of curiosity, why is sad.h needed? I don't see anything in it that I
>> can think of dld.h as implicitly needing.
>>
>> Its unfortunate that sad.h pollutes the namespace this way, but I think it
>> was designed with the idea that only the sad driver itself, along with
>> whatever userland component is associated with it (autopush?) would include
>> it.
>>
>> I also note that those portions of the namespace that it pollutes with do
>> not appear to be documented anywhere. Maybe they could be changed? (I
>> guess this would impact userland components like autopush?)
>>
>>
>
> don't know- Brussels inherited this part from clearview-uv- maybe
> someone there can clarify?
>
I hope so. I certainly don't like "surprise" additions to the namespace,
and this would constitute one of those.
> Thanks very much for the review!
>
You're very welcome!
-- Garrett
> --Sowmini
>
>
