Quaker, thanks very much for the code review comments!
On (11/16/07 17:18), Quaker Fang wrote: > Some nits: > ------------------------------------------ > *usr/src/cmd/dladm/Makefile > Seems no modifications > > **usr/src/lib/libdladm/Makefile.com > **usr/src/lib/libdladm/common/libdllink.h > **usr/src/lib/libdladm/common/mapfile-vers > **No comments > ** > usr/src/lib/libdladm/common/libdladm.c* > *L526 > The return value type of *dladm_get_single_mac_stat is dladm_status_t, > it's better to replace (0), (-1) with DLADM_STATUS_* Accept. -1 will be replaced with dladm_errno2status(), and 0 with DLADM_STATUS_OK. > > *usr/src/uts/common/io/ipw/ipw2100.c > **usr/src/uts/common/io/ipw/ipw2100_impl.h > These two files seem having no releation with the brussels framework > yes, they do not have a direct relationship with the framework, but were affected as part of the header file cleanup (dld.h, mac.h had some needless circular dependancies, and dld.h did not have to include mac.h). --Sowmini
