Hi Al, >>>>> Al Haji-Ali <[email protected]> writes: > On 02/10/2025, Al Haji-Ali wrote: >> This patch (last one before preview-point implementation) refactors >> code for creating and starting preview processes.
> @Arash, @Ikumi, please let me know if there's anything I can do to > make reviewing this patch easier (like splitting or joining changes). Sorry for further delay, I've been laid up with a terrible cold since Sunday night, and I've finally managed to get back to reviewing. Your proposal basically looks good to me and I think we can accept it. There is one minor concern: why do you treat dvisvgm as if it were a variant of dvipng? It seems more intuitive to introduce `preview-dvisvgm-process-setup', `preview-start-dvisvgm' etc. -(defun preview-dvipng-process-setup () - "Set up dvipng process for conversion." +(defun preview-dvi*-process-setup-1 (img-type start sentinel) + "Setup process of a DVI converter to IMG-TYPE. +START is the function that actually starts the process and SENTINEL is +the used `TeX-sentinel-function'." The last sentence seems to lack a word between "the" and "used" (and possibly "by" is also missing?) Regards, Ikumi Keita #StandWithUkraine #StopWarInUkraine #Gaza #StopGenocide #CeasefireNOW _______________________________________________ bug-auctex mailing list [email protected] https://lists.gnu.org/mailman/listinfo/bug-auctex
