Hi Al,

Al Haji-Ali <[email protected]> writes:

> Attached is the patch announcing the changes and updating the
> documentation where `dvipng` was previously mentioned.

thank you.  I slightly touched your patch (see file attached) and pushed
it.  Please let me know if you're happy with it, and we can close this
and move to the next round :-)

Best, Arash
diff --git a/NEWS.org b/NEWS.org
index 09635277..ddfcd55c 100644
--- a/NEWS.org
+++ b/NEWS.org
@@ -30,9 +30,8 @@
   macros as =slide-title=.  This affects macros provided by
   =style/beamer.el= and =style/ltx-talk.el=.
 
-- Change the name of ~preview-dvipng-command~ to
-  ~preview-dvi*-command~. Also make it accept a function symbol
-  returning the full command.
+- Change the name of ~preview-dvipng-command~ to ~preview-dvi*-command~.
+  Also make it accept a function symbol returning the full command.
 
 - Change the name of ~preview-dvipng-image-type~ to
   ~preview-dvi*-image-type~.
diff --git a/doc/preview-latex.texi b/doc/preview-latex.texi
index 1b78197b..19210a35 100644
--- a/doc/preview-latex.texi
+++ b/doc/preview-latex.texi
@@ -719,40 +719,35 @@ cater for the images that are displayed.  There are various options
 customizable concerning aspects of that operation, see the customization
 group @samp{Preview Gs} for this.
 
-Another noteworthy setting of @code{preview-image-type} is
-@samp{dvi*}: in this case, A DVI conversion process will be run (for example
+Another noteworthy setting of @code{preview-image-type} is @samp{dvi*}: in
+this case, a @acronym{DVI} conversion process will be run (for example
 @command{dvipng}
 @pindex dvipng
-or
-@command{dvisvgm}
-)
-on the @acronym{DVI} output (see below for @acronym{PDF}).
-This is in general much faster than Dvips and Ghostscript.  In that
-case, the option
+or @command{dvisvgm}) on the @acronym{DVI} output (see below for
+@acronym{PDF}).  This is in general much faster than Dvips and
+Ghostscript.  In that case, the option
 
 @item preview-dvi*-command
 will determine the command to run for the conversion, and it is expected that
 
 @item preview-dvi*-image-type
-images get produced (@samp{dvipng} might be configured for PNG or other image
-and @samp{dvisvgm}
-produces SVG images that you can use if your Emacs supports them
-).
-You will notice that @code{preview-gs-image-type-alist}
-contains an entry for @code{dvi*}: this actually has nothing to with
-the @acronym{DVI} conversion itself but specifies the image type and Ghostscript device
-option to use when such conversion can't be done.  This will obviously be
-the case for @acronym{PDF} output by PDF@LaTeX{}, but it will also happen
-if the @acronym{DVI} file contains PostScript specials in which case the
-affected images will get run through Dvips and Ghostscript once
-the @acronym{DVI} conversion process finishes.
-
-Note for p@LaTeX{} and up@LaTeX{} users: It is known that @command{dvipng} and
-@command{dvisvgm}
-are not compatible with p@LaTeX{} and up@LaTeX{}.  If
-@code{preview-image-type} is set to @samp{dvi*} and (u)p@LaTeX{} is
-used, the @acronym{DVI} conversion process just fails and @previewlatex{} falls back on
-Dvips and Ghostscript.
+images get produced (@samp{dvipng} might be configured for PNG or other
+image and @samp{dvisvgm} produces SVG images that you can use if your
+Emacs supports them).  You will notice that
+@code{preview-gs-image-type-alist} contains an entry for @code{dvi*}: this
+actually has nothing to do with the @acronym{DVI} conversion itself but
+specifies the image type and Ghostscript device option to use when such
+conversion can't be done.  This will obviously be the case for
+@acronym{PDF} output by PDF@LaTeX{}, but it will also happen if the
+@acronym{DVI} file contains PostScript specials in which case the affected
+images will get run through Dvips and Ghostscript once the @acronym{DVI}
+conversion process finishes.
+
+Note for p@LaTeX{} and up@LaTeX{} users: It is known that @command{dvipng}
+and @command{dvisvgm} are not compatible with p@LaTeX{} and up@LaTeX{}.
+If @code{preview-image-type} is set to @samp{dvi*} and (u)p@LaTeX{} is
+used, the @acronym{DVI} conversion process just fails and @previewlatex{}
+falls back on Dvips and Ghostscript.
 
 @item preview-gs-options
 Most interesting to the user perhaps is the setting of this variable.
diff --git a/doc/preview-readme.texi b/doc/preview-readme.texi
index 0da604ce..2f4f3cc4 100644
--- a/doc/preview-readme.texi
+++ b/doc/preview-readme.texi
@@ -49,9 +49,9 @@ constructs, does this only when told, and then right in the source code.
 Switching back and forth between the source and preview is easy and
 natural and can be done for each image independently.  Behind the scenes
 of @previewlatex{}, a sophisticated framework of other programs like
-@samp{dvipng}, @samp{dvisvgm}, Dvips and Ghostscript are employed together with a
-special @LaTeX{} style file for extracting the material of interest in
-the background and providing fast interactive response.
+@samp{dvipng}, @samp{dvisvgm}, Dvips and Ghostscript are employed together
+with a special @LaTeX{} style file for extracting the material of interest
+in the background and providing fast interactive response.
 
 @node  Activating preview-latex, Getting started, What use is it?, Introduction
 @section Activating @previewlatex{}
diff --git a/preview.el b/preview.el
index 72da6e78..94812886 100644
--- a/preview.el
+++ b/preview.el
@@ -206,7 +206,7 @@ of Ghostscript, or by your copy of Emacs."
                                          (repeat :tag "Additional \
 function args" :inline t sexp))
                        :options (open place close)))
-  :package-version '(auctex . "14.2"))
+  :package-version '(auctex . "14.2.0"))
 
 (defcustom preview-gs-image-type-alist
   '((png png "-sDEVICE=png16m")
@@ -222,7 +222,7 @@ method, like when PDFTeX was used."
   :type '(repeat (list :tag nil (symbol :tag "preview image-type")
                        (symbol :tag "Emacs image-type")
                        (repeat :inline t :tag "Ghostscript options" string)))
-  :package-version '(auctex . "14.2"))
+  :package-version '(auctex . "14.2.0"))
 
 (defcustom preview-image-type 'png
   "Image type to be used in images."
@@ -516,7 +516,7 @@ an explicit list of elements in the CDR, or a symbol to
 be consulted recursively.")
 
 (define-obsolete-variable-alias
-  'preview-dvipng-command 'preview-dvi*-command "14.2")
+  'preview-dvipng-command 'preview-dvi*-command "14.2.0")
 (defcustom preview-dvi*-command
   "dvipng -picky -noghostscript %d -o %m/prev%%03d.png"
   "Command used for converting to separate PNG images.
@@ -528,10 +528,10 @@ You might specify options for converting to other image types,
 but then you'll need to adapt `preview-dvi*-image-type'."
   :group 'preview-latex
   :type '(choice string function)
-  :package-version '(auctex . "14.2"))
+  :package-version '(auctex . "14.2.0"))
 
 (define-obsolete-variable-alias
-  'preview-dvipng-image-type 'preview-dvi*-image-type "14.2")
+  'preview-dvipng-image-type 'preview-dvi*-image-type "14.2.0")
 (defcustom preview-dvi*-image-type
   'png
   "Image type that dvi conversion produces.
@@ -542,7 +542,7 @@ customize this."
   :type '(choice (const png)
                  (const gif)
                  (symbol :tag "Other" :value png))
-  :package-version '(auctex . "14.2"))
+  :package-version '(auctex . "14.2.0"))
 
 (defun preview-dvipng-command (&optional cmd)
   "Return a shell command for running dvipng.
@@ -971,7 +971,7 @@ START is the function that actually starts the process with
    #'preview-start-dvi*
    #'preview-dvi*-sentinel))
 (define-obsolete-function-alias
-  'preview-dvipng-process-setup #'preview-dvi*-process-setup "14.2")
+  'preview-dvipng-process-setup #'preview-dvi*-process-setup "14.2.0")
 
 (defun preview-pdf2dsc-process-setup ()
   (setq TeX-sentinel-function #'preview-pdf2dsc-sentinel)
@@ -1004,7 +1004,7 @@ START is the function that actually starts the process with
 (defalias 'preview-dvi*-abort #'preview-dvips-abort)
 ;  "Abort a dvi conversion run.")
 (define-obsolete-function-alias
-  'preview-dvipng-abort #'preview-dvi*-abort "14.2")
+  'preview-dvipng-abort #'preview-dvi*-abort "14.2.0")
 
 (defun preview-gs-dvips-sentinel (process _command &optional gsstart)
   "Sentinel function for indirect rendering DviPS process.
@@ -1114,7 +1114,7 @@ The usual PROCESS and COMMAND arguments for
     (error (preview-log-error err "Dvi conversion sentinel" process)))
   (preview-reraise-error process))
 (define-obsolete-function-alias
-  'preview-dvipng-sentinel #'preview-dvi*-sentinel "14.2")
+  'preview-dvipng-sentinel #'preview-dvi*-sentinel "14.2.0")
 
 (defun preview-dvi*-close (process closedata)
   "Clean up after PROCESS and set up queue accumulated in CLOSEDATA."
@@ -1140,7 +1140,7 @@ The usual PROCESS and COMMAND arguments for
           (unless (eq (process-status process) 'signal)
             (preview-dvi*-abort))))))
 (define-obsolete-function-alias
-  'preview-dvipng-close #'preview-dvi*-close "14.2")
+  'preview-dvipng-close #'preview-dvi*-close "14.2.0")
 
 (defun preview-dsc-parse (file)
   "Parse DSC comments of FILE.
@@ -2663,7 +2663,7 @@ Deletes the dvi file when finished."
           (preview-delete-file filename)
         (file-error nil)))))
 (define-obsolete-function-alias
-  'preview-dvipng-place-all #'preview-dvi*-place-all "14.2")
+  'preview-dvipng-place-all #'preview-dvi*-place-all "14.2.0")
 
 (defun preview-active-string (ov)
   "Generate before-string for active image overlay OV."
@@ -3936,7 +3936,7 @@ The fourth value is the transparent border thickness."
        (preview-dvipng-command preview-dvi*-command)
      (funcall preview-dvi*-command))))
 (define-obsolete-function-alias
-  'preview-start-dvipng #'preview-start-dvi* "14.2")
+  'preview-start-dvipng #'preview-start-dvi* "14.2.0")
 
 (defun preview-start-dvips (&optional fast)
   "Start a DviPS process.
_______________________________________________
bug-auctex mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-auctex

Reply via email to