Hi Al, >>>>> Al Haji-Ali <[email protected]> writes: > I agree that dvisvgm being a variant of dvipng is weird, that is why I > proposed in the second patch I attached to rename all symbols to > `preview-dvi*-process-setup`, `preview-start-dvi*` etc so that they > include both dvipng and dvisvgm as two customization of a common > interface (the obsolete aliases would ensure code is still backward > compatible).
> The other option, as you said, is to introduce new functions which call > helper functions with TYPE and COMMAND arguments fixed to those > compatible with dvipng or dvisvgm. > This is what I did first (I can probably recover it from my > preview-point branch), but I found it to be too cumbersome as I had to > pass TYPE and COMMAND from function to functions to sentinels (and had > to change the interface of existing functions to accept those > arguments). It also required some code duplication. > Overall, it felt more natural to treat the dvi conversion as the key > feature, rather than the output file which can be customized. > Let me know if you disagree, and what you think about the second path > renaming functions. OK, your second patch approach seems reasonable to me. I'm still busy catching up on various things that piled up while I was sick, so I haven't been able to get to it yet, but I'll take care of it eventually. >> -(defun preview-dvipng-process-setup () >> - "Set up dvipng process for conversion." >> +(defun preview-dvi*-process-setup-1 (img-type start sentinel) >> + "Setup process of a DVI converter to IMG-TYPE. >> +START is the function that actually starts the process and SENTINEL is >> +the used `TeX-sentinel-function'." >> >> The last sentence seems to lack a word between "the" and "used" (and >> possibly "by" is also missing?) > It's my awkward phrasing. > Perhaps simply: "START is the function that actually starts the process > with `TeX-sentinel-function' set to SENTINEL." Looks good. Regards, Ikumi Keita #StandWithUkraine #StopWarInUkraine #Gaza #StopGenocide #CeasefireNOW _______________________________________________ bug-auctex mailing list [email protected] https://lists.gnu.org/mailman/listinfo/bug-auctex
