Hi Al,
> Sounds good. I've attached my updated patch here (updated to on top of
> 16c3da1bcb). I am thinking that your patch implementing the variable
> watching should be a different commit (for appropriate credit and future
> git-blaming).
Sure, can do.
I took another glance. Minor doc comment:
> +
> +@item Customize where previews are shown
> +
> +Set @code{preview-visibility-style} to control when previews appear:
> +
> +@table @code
> +
> +@item off-point
> +Default. Previews replace the source when point is elsewhere. When a
> +preview is opened to show the source, the preview is replaced by an icon.
> +
> +@item at-point
> +Previews never obscure the source. When the cursor enters the source, the
> +preview, if there is one, appears alongside it.
> +
> +@item always
> +Previews are always visible when available. Away from point they replace
> +the source; when opened they remain displayed alongside the source.
> +
> +@end table
> +
I feel that somewhere in the above, the role of preview-auto-reveal
should be noted. For instance, if preview-auto-reveal is set
restrictively, then "cursor enters the source" is not sufficient in the
docs of at-point.
The attribution line in the commit message is appreciated, but I think
the customary way to do this is just to write "(bug#79708)" at the end
of the commit, which points back to the whole conversation.
I suppose we are ready to merge this, then? Anyone object?
Thanks, best,
Paul
_______________________________________________
bug-auctex mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-auctex
